認証エンドポイントの修正とリファクタリング #8
Open
+33
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SasakiTakatsugu
requested review from
KooriyamaHiroki,
YasuhiroTakahashi,
bigdragon0610,
Copilot and
silent-bayline
There was a problem hiding this comment.
Pull Request Overview
This PR refactors authentication credential handling by replacing the third-party CallbackApiController with a custom implementation in IndexController. The changes consolidate credential retrieval logic within the application's own controller and fix the refresh token authentication flow.
Key changes:
- Removed dependency on
CallbackApiControllerand implemented customcredentials()method - Fixed
refresh()method to use correct API parameter format - Standardized both methods to use the same API call pattern with proper response handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| routes/api.php | Updated /credentials route to use IndexController::credentials instead of external CallbackApiController |
| app/Http/Controllers/IndexController.php | Added credentials() method and refactored refresh() method with corrected parameter structure and consistent error logging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
silent-bayline
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更内容
refreshエンドポイントのバグ修正（連想配列とFETCH_RESPONSEを使用）credentialsエンドポイントをCallbackApiControllerからIndexControllerに移行